Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from noir #10290

Closed
wants to merge 8 commits into from
Closed

feat: Sync from noir #10290

wants to merge 8 commits into from

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: used signed division for signed modulo (noir-lang/noir#6635)
fix(ssa): don't deduplicate constraints in blocks that are not dominated (noir-lang/noir#6627)
chore: pin foundry version in CI (noir-lang/noir#6642)
feat(ssa): Deduplicate intrinsics with predicates (noir-lang/noir#6615)
chore: improve error message of &T (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove ec module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow #[export] on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify jmpifs by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from num_bits (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add array_refcount and slice_refcount builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove compiler_version from new Nargo.toml (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments (noir-lang/noir#6548)
fix: correct type when simplifying derive_pedersen_generators (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
END_COMMIT_OVERRIDE

AztecBot and others added 6 commits November 28, 2024 18:26
@AztecBot
[1 changes] fix: used signed division for signed modulo (noir-lang/no…
36c0aa3 
…ir#6635)

fix(ssa): don't deduplicate constraints in blocks that are not dominated (noir-lang/noir#6627)
chore: pin foundry version in CI (noir-lang/noir#6642)
feat(ssa): Deduplicate intrinsics with predicates (noir-lang/noir#6615)
chore: improve error message of `&T` (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove `ec` module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
@AztecBot
chore: apply sync fixes
758aeb5
@TomAFrench
.
39a131e
@TomAFrench
Merge branch 'master' into sync-noir
1a6392e
@TomAFrench
.
e9da23a
@TomAFrench
.
fed485a
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: aaab50680a2121a47a1b69e2df108ccda226a151, compared to commit: c48ae90c5d72450a3a19b76e552df1607ff79953

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
TokenBridge::exit_to_l1_public +136 ❌ +2.15%
Lending::withdraw_public +13 ❌ +0.69%
Lending::borrow_public +13 ❌ +0.69%
FPC::prepare_fee +13 ❌ +0.65%
FPC::pay_refund +13 ❌ +0.64%
StaticParent::public_nested_static_call +13 ❌ +0.64%
Lending::repay_public +13 ❌ +0.54%
Lending::deposit_public +13 ❌ +0.51%
AvmTest::u128_from_integer_overflow -4 ✅ -0.49%
AvmTest::u128_addition_overflow -8 ✅ -0.60%
AvmTest::keccak_hash -17 ✅ -0.71%
AvmTest::bulk_testing -162 ✅ -0.72%
AvmTest::emit_unencrypted_log -21 ✅ -0.76%
Router::_check_timestamp -8 ✅ -0.81%
Router::_check_block_number -8 ✅ -0.82%
Lending::_withdraw -74 ✅ -0.86%
Token::complete_refund -47 ✅ -0.87%
Test::emit_unencrypted -13 ✅ -0.88%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -55 ✅ -0.90%
CardGame::on_game_joined -51 ✅ -1.01%
TokenBlacklist::constructor -64 ✅ -1.03%
NFT::_store_payload_in_transient_storage_unsafe -13 ✅ -1.10%
Token::_store_payload_in_transient_storage_unsafe -13 ✅ -1.10%
TestLog::emit_unencrypted_events -13 ✅ -1.13%
Lending::_borrow -87 ✅ -1.18%
TokenBlacklist::update_roles -74 ✅ -1.21%
TokenBlacklist::shield -74 ✅ -1.28%
TokenBlacklist::transfer_public -74 ✅ -1.32%
StaticParent::public_dispatch -77 ✅ -1.34%
Lending::update_accumulator -77 ✅ -1.34%
Auth::set_authorized_delay -64 ✅ -1.38%
Uniswap::swap_public -210 ✅ -1.39%
Auth::set_authorized -64 ✅ -1.41%
CardGame::on_cards_claimed -103 ✅ -1.41%
TokenBlacklist::burn_public -74 ✅ -1.42%
AvmTest::sha256_hash -60 ✅ -1.53%
Lending::_repay -87 ✅ -1.53%
Token::constructor -68 ✅ -1.65%
NFT::constructor -68 ✅ -1.68%
TokenBlacklist::mint_private -64 ✅ -1.71%
Token::transfer_in_public -74 ✅ -1.75%
Token::burn_public -74 ✅ -1.78%
TokenBlacklist::mint_public -74 ✅ -1.85%
NFT::transfer_in_public -64 ✅ -1.92%
Parent::public_dispatch -150 ✅ -1.97%
Token::_finalize_mint_to_private_unsafe -124 ✅ -2.01%
Token::finalize_mint_to_private -124 ✅ -2.03%
Token::_finalize_transfer_to_private_unsafe -134 ✅ -2.04%
Token::finalize_transfer_to_private -134 ✅ -2.06%
Uniswap::public_dispatch -475 ✅ -2.07%
AuthWitTest::public_dispatch -35 ✅ -2.11%
AuthRegistry::consume -64 ✅ -2.22%
AppSubscription::constructor -64 ✅ -2.26%
Auth::public_dispatch -199 ✅ -2.26%
NFT::_finalize_transfer_to_private_unsafe -124 ✅ -2.27%
NFT::finalize_transfer_to_private -124 ✅ -2.29%
StatefulTest::public_constructor -64 ✅ -2.30%
Crowdfunding::init -64 ✅ -2.36%
TokenBlacklist::get_roles -64 ✅ -2.39%
Parent::public_nested_static_call -81 ✅ -2.41%
AppSubscription::public_dispatch -99 ✅ -2.48%
TokenBridge::claim_public -280 ✅ -2.49%
TestLog::public_dispatch -60 ✅ -2.59%
Test::consume_mint_to_public_message -280 ✅ -2.60%
Lending::init -77 ✅ -2.61%
Test::consume_message_from_arbitrary_sender_public -210 ✅ -2.65%
AvmTest::returndata_copy_oracle -47 ✅ -2.66%
Auth::constructor -64 ✅ -2.66%
EasyPrivateVoting::constructor -64 ✅ -2.66%
Uniswap::constructor -64 ✅ -2.71%
TokenBlacklist::public_dispatch -628 ✅ -2.71%
Crowdfunding::_publish_donation_receipts -26 ✅ -2.73%
InclusionProofs::constructor -64 ✅ -2.78%
AvmInitializerTest::public_dispatch -77 ✅ -2.84%
Lending::_deposit -77 ✅ -3.04%
Token::mint_to_public -87 ✅ -3.04%
Token::public_dispatch -998 ✅ -3.17%
TokenBridge::public_dispatch -653 ✅ -3.19%
NFT::mint -92 ✅ -3.24%
AuthRegistry::public_dispatch -260 ✅ -3.28%
AvmTest::public_dispatch -2,001 ✅ -3.30%
Spam::public_spam -82 ✅ -3.38%
Benchmarking::increment_balance -82 ✅ -3.44%
FeeJuice::check_balance -77 ✅ -3.47%
FeeJuice::_increase_public_balance -77 ✅ -3.47%
TokenBlacklist::_increase_public_balance -87 ✅ -3.50%
Token::_increase_public_balance -87 ✅ -3.50%
Lending::get_asset -77 ✅ -3.50%
Spam::public_dispatch -116 ✅ -3.58%
PriceFeed::public_dispatch -111 ✅ -3.59%
Lending::get_position -181 ✅ -3.62%
Router::public_dispatch -86 ✅ -3.64%
Claim::constructor -90 ✅ -3.67%
CardGame::on_card_played -219 ✅ -3.68%
EasyPrivateVoting::add_to_tally_public -77 ✅ -3.75%
Auth::get_authorized_delay -77 ✅ -3.75%
NFT::owner_of -92 ✅ -3.79%
Claim::public_dispatch -124 ✅ -3.81%
TokenBridge::constructor -90 ✅ -3.82%
FPC::constructor -90 ✅ -3.88%
StatefulTest::public_dispatch -239 ✅ -3.90%
Lending::public_dispatch -1,060 ✅ -3.92%
FPC::public_dispatch -281 ✅ -3.94%
AvmInitializerTest::constructor -77 ✅ -3.94%
CardGame::start_game -277 ✅ -3.94%
Auth::get_authorized -77 ✅ -4.03%
CardGame::public_dispatch -643 ✅ -4.03%
AuthRegistry::is_consumable -77 ✅ -4.04%
Crowdfunding::public_dispatch -189 ✅ -4.04%
AuthRegistry::_set_authorized -77 ✅ -4.05%
AvmTest::add_storage_map -77 ✅ -4.05%
TokenBlacklist::balance_of_public -77 ✅ -4.05%
Token::balance_of_public -77 ✅ -4.05%
AuthRegistry::set_authorized -77 ✅ -4.15%
FeeJuice::balance_of_public -77 ✅ -4.17%
Auth::get_scheduled_authorized -77 ✅ -4.25%
NFT::public_dispatch -1,010 ✅ -4.26%
PriceFeed::set_price -77 ✅ -4.27%
AvmTest::get_args_hash -77 ✅ -4.27%
NFT::set_minter -77 ✅ -4.27%
Token::set_minter -77 ✅ -4.27%
NFT::is_minter -77 ✅ -4.28%
Token::is_minter -77 ✅ -4.28%
AvmTest::set_storage_map -77 ✅ -4.28%
NFT::_finish_transfer_to_public -77 ✅ -4.31%
Benchmarking::broadcast -77 ✅ -4.34%
Test::public_dispatch -831 ✅ -4.35%
PriceFeed::get_price -77 ✅ -4.39%
StatefulTest::increment_public_value -77 ✅ -4.40%
AuthRegistry::is_reject_all -77 ✅ -4.41%
StatefulTest::get_public_value -77 ✅ -4.43%
AvmTest::poseidon2_hash -77 ✅ -4.45%
AvmTest::read_storage_map -77 ✅ -4.51%
AuthRegistry::set_reject_all -77 ✅ -4.52%
StatefulTest::increment_public_value_no_init_check -77 ✅ -4.52%
FeeJuice::public_dispatch -261 ✅ -4.94%
Child::public_dispatch -238 ✅ -4.99%
InclusionProofs::public_dispatch -212 ✅ -5.64%
StaticChild::public_dispatch -124 ✅ -5.87%
Benchmarking::public_dispatch -264 ✅ -6.66%
DocsExample::public_dispatch -300 ✅ -7.16%
EasyPrivateVoting::public_dispatch -518 ✅ -9.96%
Lending::get_assets -86 ✅ -16.60%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
TokenBridge::exit_to_l1_public 6,463 (+136) +2.15%
Lending::withdraw_public 1,907 (+13) +0.69%
Lending::borrow_public 1,907 (+13) +0.69%
FPC::prepare_fee 1,999 (+13) +0.65%
FPC::pay_refund 2,054 (+13) +0.64%
StaticParent::public_nested_static_call 2,059 (+13) +0.64%
Lending::repay_public 2,438 (+13) +0.54%
Lending::deposit_public 2,555 (+13) +0.51%
AvmTest::u128_from_integer_overflow 813 (-4) -0.49%
AvmTest::u128_addition_overflow 1,329 (-8) -0.60%
AvmTest::keccak_hash 2,381 (-17) -0.71%
AvmTest::bulk_testing 22,471 (-162) -0.72%
AvmTest::emit_unencrypted_log 2,756 (-21) -0.76%
Router::_check_timestamp 985 (-8) -0.81%
Router::_check_block_number 968 (-8) -0.82%
Lending::_withdraw 8,559 (-74) -0.86%
Token::complete_refund 5,326 (-47) -0.87%
Test::emit_unencrypted 1,471 (-13) -0.88%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,087 (-55) -0.90%
CardGame::on_game_joined 4,976 (-51) -1.01%
TokenBlacklist::constructor 6,163 (-64) -1.03%
NFT::_store_payload_in_transient_storage_unsafe 1,172 (-13) -1.10%
Token::_store_payload_in_transient_storage_unsafe 1,172 (-13) -1.10%
TestLog::emit_unencrypted_events 1,136 (-13) -1.13%
Lending::_borrow 7,304 (-87) -1.18%
TokenBlacklist::update_roles 6,058 (-74) -1.21%
TokenBlacklist::shield 5,717 (-74) -1.28%
TokenBlacklist::transfer_public 5,529 (-74) -1.32%
StaticParent::public_dispatch 5,687 (-77) -1.34%
Lending::update_accumulator 5,665 (-77) -1.34%
Auth::set_authorized_delay 4,576 (-64) -1.38%
Uniswap::swap_public 14,952 (-210) -1.39%
Auth::set_authorized 4,480 (-64) -1.41%
CardGame::on_cards_claimed 7,195 (-103) -1.41%
TokenBlacklist::burn_public 5,149 (-74) -1.42%
AvmTest::sha256_hash 3,855 (-60) -1.53%
Lending::_repay 5,583 (-87) -1.53%
Token::constructor 4,057 (-68) -1.65%
NFT::constructor 3,982 (-68) -1.68%
TokenBlacklist::mint_private 3,673 (-64) -1.71%
Token::transfer_in_public 4,143 (-74) -1.75%
Token::burn_public 4,093 (-74) -1.78%
TokenBlacklist::mint_public 3,922 (-74) -1.85%
NFT::transfer_in_public 3,263 (-64) -1.92%
Parent::public_dispatch 7,479 (-150) -1.97%
Token::_finalize_mint_to_private_unsafe 6,031 (-124) -2.01%
Token::finalize_mint_to_private 5,984 (-124) -2.03%
Token::_finalize_transfer_to_private_unsafe 6,428 (-134) -2.04%
Token::finalize_transfer_to_private 6,381 (-134) -2.06%
Uniswap::public_dispatch 22,496 (-475) -2.07%
AuthWitTest::public_dispatch 1,624 (-35) -2.11%
AuthRegistry::consume 2,824 (-64) -2.22%
AppSubscription::constructor 2,770 (-64) -2.26%
Auth::public_dispatch 8,591 (-199) -2.26%
NFT::_finalize_transfer_to_private_unsafe 5,343 (-124) -2.27%
NFT::finalize_transfer_to_private 5,296 (-124) -2.29%
StatefulTest::public_constructor 2,723 (-64) -2.30%
Crowdfunding::init 2,652 (-64) -2.36%
TokenBlacklist::get_roles 2,618 (-64) -2.39%
Parent::public_nested_static_call 3,279 (-81) -2.41%
AppSubscription::public_dispatch 3,896 (-99) -2.48%
TokenBridge::claim_public 10,981 (-280) -2.49%
TestLog::public_dispatch 2,260 (-60) -2.59%
Test::consume_mint_to_public_message 10,487 (-280) -2.60%
Lending::init 2,876 (-77) -2.61%
Test::consume_message_from_arbitrary_sender_public 7,703 (-210) -2.65%
AvmTest::returndata_copy_oracle 1,722 (-47) -2.66%
Auth::constructor 2,342 (-64) -2.66%
EasyPrivateVoting::constructor 2,338 (-64) -2.66%
Uniswap::constructor 2,301 (-64) -2.71%
TokenBlacklist::public_dispatch 22,550 (-628) -2.71%
Crowdfunding::_publish_donation_receipts 927 (-26) -2.73%
InclusionProofs::constructor 2,237 (-64) -2.78%
AvmInitializerTest::public_dispatch 2,633 (-77) -2.84%
Lending::_deposit 2,459 (-77) -3.04%
Token::mint_to_public 2,776 (-87) -3.04%
Token::public_dispatch 30,496 (-998) -3.17%
TokenBridge::public_dispatch 19,839 (-653) -3.19%
NFT::mint 2,748 (-92) -3.24%
AuthRegistry::public_dispatch 7,678 (-260) -3.28%
AvmTest::public_dispatch 58,661 (-2,001) -3.30%
Spam::public_spam 2,347 (-82) -3.38%
Benchmarking::increment_balance 2,299 (-82) -3.44%
FeeJuice::check_balance 2,145 (-77) -3.47%
FeeJuice::_increase_public_balance 2,142 (-77) -3.47%
TokenBlacklist::_increase_public_balance 2,401 (-87) -3.50%
Token::_increase_public_balance 2,401 (-87) -3.50%
Lending::get_asset 2,123 (-77) -3.50%
Spam::public_dispatch 3,128 (-116) -3.58%
PriceFeed::public_dispatch 2,982 (-111) -3.59%
Lending::get_position 4,819 (-181) -3.62%
Router::public_dispatch 2,275 (-86) -3.64%
Claim::constructor 2,363 (-90) -3.67%
CardGame::on_card_played 5,730 (-219) -3.68%
EasyPrivateVoting::add_to_tally_public 1,976 (-77) -3.75%
Auth::get_authorized_delay 1,974 (-77) -3.75%
NFT::owner_of 2,337 (-92) -3.79%
Claim::public_dispatch 3,128 (-124) -3.81%
TokenBridge::constructor 2,267 (-90) -3.82%
FPC::constructor 2,228 (-90) -3.88%
StatefulTest::public_dispatch 5,893 (-239) -3.90%
Lending::public_dispatch 26,007 (-1,060) -3.92%
FPC::public_dispatch 6,850 (-281) -3.94%
AvmInitializerTest::constructor 1,875 (-77) -3.94%
CardGame::start_game 6,745 (-277) -3.94%
Auth::get_authorized 1,836 (-77) -4.03%
CardGame::public_dispatch 15,310 (-643) -4.03%
AuthRegistry::is_consumable 1,831 (-77) -4.04%
Crowdfunding::public_dispatch 4,485 (-189) -4.04%
AuthRegistry::_set_authorized 1,824 (-77) -4.05%
AvmTest::add_storage_map 1,824 (-77) -4.05%
TokenBlacklist::balance_of_public 1,822 (-77) -4.05%
Token::balance_of_public 1,822 (-77) -4.05%
AuthRegistry::set_authorized 1,777 (-77) -4.15%
FeeJuice::balance_of_public 1,768 (-77) -4.17%
Auth::get_scheduled_authorized 1,736 (-77) -4.25%
NFT::public_dispatch 22,674 (-1,010) -4.26%
PriceFeed::set_price 1,728 (-77) -4.27%
AvmTest::get_args_hash 1,727 (-77) -4.27%
NFT::set_minter 1,727 (-77) -4.27%
Token::set_minter 1,727 (-77) -4.27%
NFT::is_minter 1,724 (-77) -4.28%
Token::is_minter 1,724 (-77) -4.28%
AvmTest::set_storage_map 1,722 (-77) -4.28%
NFT::_finish_transfer_to_public 1,709 (-77) -4.31%
Benchmarking::broadcast 1,698 (-77) -4.34%
Test::public_dispatch 18,294 (-831) -4.35%
PriceFeed::get_price 1,676 (-77) -4.39%
StatefulTest::increment_public_value 1,674 (-77) -4.40%
AuthRegistry::is_reject_all 1,670 (-77) -4.41%
StatefulTest::get_public_value 1,660 (-77) -4.43%
AvmTest::poseidon2_hash 1,652 (-77) -4.45%
AvmTest::read_storage_map 1,629 (-77) -4.51%
AuthRegistry::set_reject_all 1,625 (-77) -4.52%
StatefulTest::increment_public_value_no_init_check 1,625 (-77) -4.52%
FeeJuice::public_dispatch 5,026 (-261) -4.94%
Child::public_dispatch 4,532 (-238) -4.99%
InclusionProofs::public_dispatch 3,550 (-212) -5.64%
StaticChild::public_dispatch 1,988 (-124) -5.87%
Benchmarking::public_dispatch 3,699 (-264) -6.66%
DocsExample::public_dispatch 3,890 (-300) -7.16%
EasyPrivateVoting::public_dispatch 4,681 (-518) -9.96%
Lending::get_assets 432 (-86) -16.60%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Changes to circuit sizes

Generated at commit: aaab50680a2121a47a1b69e2df108ccda226a151, compared to commit: c48ae90c5d72450a3a19b76e552df1607ff79953

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private +450,743 ❌ +266.44% +1,799,748 ❌ +68.76%
rollup_base_public +503,735 ❌ +141.63% +1,889,280 ❌ +48.84%
private_kernel_reset +31,516 ❌ +35.15% +48,210 ❌ +7.56%
private_kernel_tail_to_public -558 ✅ -3.66% +1,218 ❌ +4.60%
private_kernel_reset_4_4_4_4_4_4_4_4_1 +5,918 ❌ +15.95% +4,802 ❌ +4.54%
private_kernel_init -119 ✅ -0.58% +657 ❌ +1.96%
private_kernel_inner -150 ✅ -0.41% +652 ❌ +1.17%
rollup_root +1,937 ❌ +16.80% +1,947 ❌ +0.10%
rollup_block_merge +1,937 ❌ +16.78% +1,947 ❌ +0.10%
parity_root -198 ✅ -4.14% -198 ✅ -0.01%
rollup_merge -132 ✅ -4.06% -132 ✅ -0.01%
rollup_block_root -262 ✅ -6.06% -280 ✅ -0.01%
parity_base -198 ✅ -4.89% -198 ✅ -0.65%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 619,917 (+450,743) +266.44% 4,417,057 (+1,799,748) +68.76%
rollup_base_public 859,409 (+503,735) +141.63% 5,757,217 (+1,889,280) +48.84%
private_kernel_reset 121,178 (+31,516) +35.15% 685,689 (+48,210) +7.56%
private_kernel_tail_to_public 14,695 (-558) -3.66% 27,679 (+1,218) +4.60%
private_kernel_reset_4_4_4_4_4_4_4_4_1 43,024 (+5,918) +15.95% 110,532 (+4,802) +4.54%
private_kernel_init 20,549 (-119) -0.58% 34,177 (+657) +1.96%
private_kernel_inner 36,617 (-150) -0.41% 56,500 (+652) +1.17%
rollup_root 13,465 (+1,937) +16.80% 1,860,006 (+1,947) +0.10%
rollup_block_merge 13,481 (+1,937) +16.78% 1,860,020 (+1,947) +0.10%
parity_root 4,584 (-198) -4.14% 3,636,338 (-198) -0.01%
rollup_merge 3,120 (-132) -4.06% 1,826,783 (-132) -0.01%
rollup_block_root 4,060 (-262) -6.06% 2,739,241 (-280) -0.01%
parity_base 3,851 (-198) -4.89% 30,284 (-198) -0.65%

@TomAFrench TomAFrench closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AztecBot @TomAFrench